fix(security): cast IDs to number in ActivityPub note deletion check#198
fix(security): cast IDs to number in ActivityPub note deletion check#198
Conversation
Co-authored-by: scobru <1079164+scobru@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
Fixes a security bypass in
DELETE /notecaused by strict type inequality (!==) when comparing numbers and strings. By casting bothnote.artist_idandrequest.artistIdto numbers usingNumber(), we ensure that restricted admins can only delete their own ActivityPub notes, as originally intended.PR created automatically by Jules for task 9331663236649113208 started by @scobru